-
Notifications
You must be signed in to change notification settings - Fork 46.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some release script fixes #20718
Some release script fixes #20718
Conversation
When the otp times out, we should not retry the packages that were already successfully published. We should pick up where we left off.
The "print follow up instructions" step crashes if build-info.json is not found. The new build workflow doesn't include those yet (might not need to) and since the instructions that depend on it only affect semver (latest) releases, I've moved the code to that branch. Will follow up with a proper fix, either by adding back a build-info.json file or removing that dependency and reading the commit some other way.
const run = async ({cwd, dry, packages, tags}, otp) => { | ||
clear(); | ||
const run = async ({cwd, dry, tags}, packageName, otp) => { | ||
const packagePath = join(cwd, 'build/node_modules', packageName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only real change here is I hoisted the for loop into the outer caller
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 74ac980:
|
* Retry loop should not start over from beginning When the otp times out, we should not retry the packages that were already successfully published. We should pick up where we left off. * Don't crash if build-info.json doesn't exist The "print follow up instructions" step crashes if build-info.json is not found. The new build workflow doesn't include those yet (might not need to) and since the instructions that depend on it only affect semver (latest) releases, I've moved the code to that branch. Will follow up with a proper fix, either by adding back a build-info.json file or removing that dependency and reading the commit some other way.
Fixes a few rough edges left over from my recent changes to the build + release pipeline.
Found and tested by publishing new "next" (0.0.0-dc27b5aaa) and "experimental" (0.0.0-experimental-dc27b5aaa) pre-releases.